PlainTable hard codes num_probes=6 for Bloom filter, regardless of bloom_bits_per_key
Open
- Dominant language
- C++
- Stars
- 32.1k
- Forks
- 6.9k
- Avg merge
- 32m
- Merged PRs (30d)
- 1
Description
### Expected behavior
When using PlainTable with Bloom filter, expect it to choose reasonable num_probes based on bloom_bits_per_key setting.
### Actual behavior
Always uses num_probes = 6 even when that's really bad for speed and false positive rate.
### Steps to reproduce the behavior
Just based on code inspection: https://github.com/facebook/rocksdb/blob/62829ff7510b3e0e5cd9c76316544b3527461cb0/table/plain/plain_table_factory.cc#L47
Contributor guide
Assessment
This issue has not been assessed yet.