facebook / facebook/rocksdb

Ambiguous license notice in code files

Open
#5,325 7 comments 0 reactions 1 assignee Claimed by @ramvadiv View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

Code files have this type of notice:
```
// This source code is licensed under both the GPLv2 (found in the
// COPYING file in the root directory) and Apache 2.0 License
// (found in the LICENSE.Apache file in the root directory).
```
Taken alone such a notice is a tad ambiguous? do both the GPL AND the Apache license apply at the same time? or is this choice?

Of course the README makes this clear that this is a choice (e.g. OR, not AND):

```
License

RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.
```

It would be great to have clear source code-level notices.

This has been found by @royaljust

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.