facebook / facebook/rocksdb

NotifyOnFlushCompleted not called if flush not successful

Open
#5,206 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

### Expected behavior
NotifyOnFlushCompleted function is called regardless of the status of the flush and the status is passed through via the FlushInfo to the OnFlushCompleted event listener.

### Actual behavior
NotifyOnFlushCompleted is only called if the flush is successful.

### Steps to reproduce the behavior
Initiate a shutdown of a database between a NotifyOnFlushBegin and NotifyOnFlushCompleted call. The OnFlushCompleted call is never made.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.