facebook / facebook/rocksdb

rocksdb creates LOCK and LOG files even if DB does not exist, and create_if_missing is false

Open
#5,029 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

### Expected behavior
If `create_if_missing` is false, and we point rocksdb to open some non-sense location such as `/etc`, rocksdb should fail to open the directory, without modifying anything inside said directory.

### Actual behavior
rocksdb adds files like `LOCK`, `LOG` into the directory.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the linked pull request #5819 and reproducing the issue with create_if_missing set to false against a directory such as /etc. Done means opening a nonexistent database path fails without creating LOCK or LOG files, with tests covering that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.