facebook / facebook/rocksdb

doc: wrong description about compaction picking in Leveled Compaction wiki page

Open
#4,967 1 comment 0 reactions 1 assignee Claimed by @ramvadiv View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

[Leveled Compaction](https://github.com/facebook/rocksdb/wiki/Leveled-Compaction) says:

>(if the file size is smaller than level0_file_num_compaction_trigger, compaction won't trigger from level 0, no matter how big the score is)

Since `level0_file_num_compaction_trigger` is a small value as a file size (its default value is `4`) , I think that such a comparison does not make much sense. And I browsed the source code and but failed to find the code which does the comparison. So I think that the above sentence should be removed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.