facebook / facebook/rocksdb

Removal of DNDEBUG caused Write performance degradation

Open
#4,041 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

> Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://www.facebook.com/groups/rocksdb.dev

Upgrade to last 5.13.2 version

### Expected behavior

Performance of write operation is the same

### Actual behavior

2x performance degradation

### Steps to reproduce the behavior

The problem is that key -DNDEBUG was remove from the place specified in my commit:

https://github.com/toktarev/rocksdb/commit/0f083b05cc305f1316245838dc057596b0000420.

As result we see 2x performance degradation

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.