facebook / facebook/rocksdb

Refactor DBImpl::IngestExternalFile() to validate external file first

Open
#3,844 1 comment 0 reactions 0 assignees View on GitHub
enhancement up-for-grabs
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

The `DBImpl::IngestExternalFile()` implementation checks `bg_error_` before doing any validation of the external file. This makes it hard for the caller to decide if the problem is due to a bad external file or an issue with the DB.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.