facebook / facebook/rocksdb

compaction_readahead_size doesn't work when it is larger than max_sectors_kb

Open
#12,038 16 comments 0 reactions 1 assignee Claimed by @hx235 View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

From tests I run with RocksDB 8.7 and 8.8 what I see with rareq-sz from iostat is many small reads (block sized) from compaction when compaction_readahead_size is larger than /sys/block/$device/queue/max_sectors_kb. Reducing compaction_readahead_size resolves the problem. I assume it should be smaller than max_sectors_kb+rocksdb_block_size or some other fudge factor because the readahead requested can be slightly larger than compaction_readahead_size.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.