facebook / facebook/rocksdb

Question: Why not pass write_options.memtable_insert_hint_per_batch

Open
#11,901 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

In `db_impl_write.cc`, some `WriteBatchInternal::InsertInto` calls passed param write_options.memtable_insert_hint_per_batch, some did not, I also noticed some `WriteBatchInternal::InsertInto` overload have param `hint_per_batch`, some have not.

Are these by design, are there any concerns?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.