facebook / facebook/rocksdb

Should return Status::NotFound() when FullHistoryTsLow is empty

Open
#11,093 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

https://github.com/facebook/rocksdb/blob/f515d9d2032e8aced7d92ec7bdb5aecd8585479a/db/db_impl/db_impl.cc#L1674

here it asserted when FullHistoryTsLow has not been set.
It should be more elegant to return Status::NotFound

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.