facebook / facebook/rocksdb

`MockFileSystem::GetAbsolutePath` is not compatible with Windows paths

Open
#10,455 0 comments 0 reactions 0 assignees View on GitHub
enhancement up-for-grabs windows
Dominant language
C++
Stars
32.1k
Forks
6.9k
Avg merge
32m
Merged PRs (30d)
1

Description

First, thank you so much for RocksDB. It's an amazing library I am using happily in [Oxigraph](https://github.com/oxigraph/oxigraph).

`MockFileSystem::GetAbsolutePath` implementation [fails if the path does not start with `/`](https://github.com/facebook/rocksdb/blob/e1b176d27462145b10d7ba6cbe0964ff72ad51a3/env/mock_env.cc#L610), causing problems on Windows. It would be nice to add support for Windows too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.