facebook / facebook/relay

`observeFragment` should have proper way to handle query errors

Open
#4,888 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

Currently, `observeFragment` does nothing about query errors, as it does not notify the observer at all when an error occurs. While I also think that it's inappropriate to return network errors from fragment observation, I believe it should fallback to returning missing data at least.

Contributor guide

Open the contributing guide

Research direction

Start at the observeFragment entry point and trace how query errors and observer notifications are handled. Compare the existing missing-data behavior and relevant observation tests, if present. Done means a query error produces the agreed missing-data result for the observer rather than leaving it uninformed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.