facebook / facebook/relay

Tutorial for fragments - image resizing might be misleading

Open
#4,291 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

I followed [section](https://relay.dev/docs/tutorial/fragments-1/#fragment-arguments-and-field-arguments) "Fragment arguments and field arguments" and added field arguments to `ImageFragment`. Now I pass image width and height to `Image` component but the actual images are not being resized:

![Screenshot 2023-04-21 at 14 26 48](https://user-images.githubusercontent.com/5990424/233636709-eb2c7b0d-01d6-44fe-ba0a-daced4196a4b.png)

I think it's alright that the actual server doesn't resize it (it would probably need some dependencies to do that) but it should be mentioned in the documentation. Maybe some users might be confused why the image is not being resized.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.