facebook / facebook/relay

Hooks: Errors from incremental payloads are dropped (e.g. @defer)

Open
#4,272 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

## Current Behaviour

When you have
1. A query rendered which has a deferred fragment. (`...Foo @defer`)
2. The Relay network respond initially with a partial response (`sink.next(data)`)
3. Then finally, an error is received from the network (`sink.error(error)`)...

There's code added [here](https://github.com/facebook/relay/commit/51e12d730edeeb680094c68bc1a2e4137360d0d0) in relay-hooks that essentially ignores this error and just warns on it.

## Expected Behaviour

If the incremental error payload is renderer as part of a suspended component, that component should receive the error, so its suspense error boundary can process it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.