facebook / facebook/relay

[Doc][Newsfeed] Type issue with useFragment when separating news feed content to fragment

Open
#4,183 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

In the new Relay tutorial, section ["Connections & Pagination"](https://relay.dev/docs/tutorial/connections-pagination/#step-3--lower-newsfeed-into-a-fragment), the example code will produce typing issue as it didn't provide necessary types for the news feed content separated from the original query.

Instead of
```
export default function Newsfeed() {
const queryData = useLazyLoadQuery(NewsfeedFragment, {});
const data = useFragment(NewsfeedContentsFragment, queryData);
const storyEdges = data.newsfeedStories.edges;
...
}
```

It should be
```
import type {NewsfeedQuery as NewsfeedQueryType} from './__generated__/NewsfeedQuery.graphql';
import type {NewsfeedContentsFragment$key} from './__generated__/NewsfeedContentsFragment.graphql';
...
export default function Newsfeed() {
const queryData = useLazyLoadQuery(NewsfeedQuery, {});
const data = useFragment(NewsfeedContentsFragment, queryData);
const storyEdges = data.viewer.newsfeedStories.edges;
...
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.