facebook / facebook/relay

Typesafe Updaters with TypeScript language in compiler config cause compiler to panic

Open
#3,965 6 comments 3 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

Ideally we could catch this and emit a diagnostic pointing to the use of the typesafe updater.

```
╭─[00:00]: captbaritone at moffo in ~/projects/relay-resolvers-todomvc on branch*
╰─➤ yarn relay
yarn run v1.22.18
warning ../package.json: No license field
$ relay-compiler
[INFO] querying files to compile...
[INFO] [default] compiling...
thread 'tokio-runtime-worker' panicked at 'Getters and setters with different types are not implemented in typescript. See https://github.com/microsoft/TypeScript/issues/43662', crates/relay-typegen/src/typescript.rs:240:21
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[ERROR] A thread that the Relay compiler spun up did not shut down gracefully: panic
[ERROR] Compilation failed.
[ERROR] Unable to run relay compiler. Error details:
A thread that the Relay compiler spun up did not shut down gracefully: panic
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
╭─[00:00]: captbaritone at moffo in ~/projects/relay-resolvers-todomvc on branch*
╰─➤
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.