facebook / facebook/relay

After calling refetchConnection in a pagination container cursor will not update.

Open
#2,557 3 comments 0 reactions 0 assignees View on GitHub
wontfix
Dominant language
Rust
Stars
19k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

After updating to 1.6.1 pagination is broken after calling refetchConnection.

When calling loadMore I pass in the endCursor as the cursor, but in my requests it gets passed as null.
If i refetch using a cursor then that cusor will persist for all subsequent loadMore requests.

This breaks our current implementation, and it's not clear using the documentation that anything has changed in this workflow.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue in a pagination container using refetchConnection followed by loadMore, checking whether the endCursor is passed as null or whether a refetched cursor persists. Inspect the pagination-container flow and existing tests for refetchConnection and loadMore. Done means subsequent loadMore requests use the current endCursor after refetching.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.