project-includes should overwrite project-excludes-heuristics

Open
#4,980 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Active
Tech stack
rust
Domain
tooling

Research direction

Start by reading the linked discussion in issue #2667 and tracing how project-includes, project-excludes-heuristics, and disable-project-excludes-heuristics are handled. Clarify the intended precedence and whether the disable setting remains necessary; done means the resulting behavior and coverage are agreed and tested.

Written by the indexing model from the issue text.

Description

needs-discussion
Describe the Bug

Brought up here.

I wonder how much customization we should have on this setting. Would we still need disable-project-excludes-heuristics if this issue is completed?

cc @connernilsen

Sandbox Link

No response

(Only applicable for extension issues) IDE Information

No response

Dominant language
Rust
Stars
7k
Forks
521
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from facebook/pyrefly

All issues in facebook/pyrefly

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.