facebook / facebook/pyrefly

special-case implicit-bool to exclude commonly-used patterns

Open
#4,492 0 comments 0 reactions 0 assignees View on GitHub
typechecking
Dominant language
Rust
Stars
7k
Forks
519
PR merge metrics
No merged PRs in 30d

Description

### Describe the Bug

reduce the noise, and skip the error if the value is one of the following:
- union between always-truthy classes & None
- certain container classes (how do we detect this - hardcoded list or some parent class? what is included?)

### Sandbox Link

_No response_

### (Only applicable for extension issues) IDE Information

_No response_

Contributor guide

Open the contributing guide

Research direction

The issue names no files, tests, or entry points. Start by locating the implicit-bool diagnostic and the type-checking logic for unions and containers; clarify which always-truthy classes and container classes are in scope, then add coverage showing the specified patterns no longer produce the error.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, rust
Domain
compilers, devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.