facebook / facebook/pyrefly

avoid storing line numbers in the baseline file

Open
#4,450 19 comments 0 reactions 1 assignee Claimed by @connernilsen View on GitHub
baseline
Dominant language
Rust
Stars
7k
Forks
516
PR merge metrics
No merged PRs in 30d

Description

from my understanding the line number is not used when matching errors against the baseline file, so it doesn't need to be stored.

in my experience, storing the line number results in very noisy diffs when updating the baseline file, and also means it needs to be updated much more often, since most changes to a file would result in most of the line numbers being changed (which would be annoying when #4449 is done)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.