facebook / facebook/pyrefly

union get expanded in hover

Open
#3,248 0 comments 0 reactions 1 assignee Claimed by @asukaminato0721 View on GitHub
language-server readability sqlalchemy
Dominant language
Rust
Stars
7k
Forks
516
PR merge metrics
No merged PRs in 30d

Description

### Describe the Bug

```py
from sqlalchemy import (
orm,
)
orm.relationship(...)
```

hover on relationship get this:

```py
foreign_keys: (() -> ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]) | (() -> Sequence[ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]]) | ColumnClause[Any] | DMLColumnRole | Mapped[Any] | Sequence[ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]] | _HasClauseElement[Any] | str | None = None,
remote_side: (() -> ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]) | (() -> Sequence[ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]]) | ColumnClause[Any] | DMLColumnRole | Mapped[Any] | Sequence[ColumnClause[Any] | DMLColumnRole | Mapped[Any] | _HasClauseElement[Any]] | _HasClauseElement[Any] | str | None = None,
```

but the definition is

```py
if TYPE_CHECKING:
from .relationships import _ORMColCollectionArgument
...
foreign_keys: Optional[_ORMColCollectionArgument] = None,
remote_side: Optional[_ORMColCollectionArgument] = None,
```

```py
_ORMColCollectionArgument = Union[
str,
Sequence[_ORMColCollectionElement],
Callable[[], Sequence[_ORMColCollectionElement]],
Callable[[], _ORMColCollectionElement],
_ORMColCollectionElement,
]
```

### Sandbox Link

_No response_

### (Only applicable for extension issues) IDE Information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.