facebook / facebook/pyrefly

warn when default=mutable in sqlalchemy

Open
#1,610 0 comments 0 reactions 1 assignee Claimed by @asukaminato0721 View on GitHub
sqlalchemy typechecking
Dominant language
Rust
Stars
7k
Forks
516
PR merge metrics
No merged PRs in 30d

Description

### Describe the Bug

Currently, when I type

```py
client_params: Mapped[dict] = mapped_column(JSONB, nullable=False, default={})
```

It doesn't show a warning, but it should, as https://docs.sqlalchemy.org/en/20/errors.html#python-dataclasses-error-encountered-when-creating-dataclass-for-classname.

the correct one is

```py
client_params: Mapped[dict] = mapped_column(JSONB, nullable=False, default_factory=dict)
```

### Sandbox Link

_No response_

### (Only applicable for extension issues) IDE Information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.