facebook / facebook/pyrefly

Pyrefly inserted `typing` import in sub-optimal location

Open
#1,490 5 comments 0 reactions 1 assignee Claimed by @asukaminato0721 View on GitHub
language-server
Dominant language
Rust
Stars
7k
Forks
516
PR merge metrics
No merged PRs in 30d

Description

### Describe the Bug

When I started typing `ClassVar` in a file in which I hadn't imported `typing.ClassVar`, Pyrefly brought up `ClassVar` as a completion suggestion (very helpful!), but it inserted `from typing import ClassVar` at the very top of my imports list. Ideally, it would have merged `ClassVar` into my existing `from typing import ...` line, or at least inserted the new `typing` import line right above/below the existing one.

Image

### Sandbox Link

_No response_

### (Only applicable for extension issues) IDE Information

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.