facebook / facebook/proxygen

Proxy Authentication

Open
#531 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C++
Stars
8.4k
Forks
1.5k
Avg merge
10m
Merged PRs (30d)
2

Description

When the HTTP1xCodec generates HTTP CONNECT request and waits for a response.

And when it receives status code as 200, there should not be any body according to the protocol and its working fine.

But when the server responds with 407 Proxy Authentication Required, it may send a body with it. In this case, the codec is failing and throwing an error.

Instead of directly denying the body for HTTP CONNECT request, it can be done relative to the status code from response.

Can you modify the codec accordingly.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.