facebook / facebook/prophet

Feature request: support multiple country holidays

Open
#909 6 comments 5 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

Hello,

This is because in some county like China Japan , people also would enjoy some foreign holidays .
For example , chocolate sales would grow on Valentine's Day .
Cake and apple(yes apple) sales would have large increase on Christmas Eve .

Current behaviour
```
>>> m.add_country_holidays('CN')
>>> m.add_country_holidays('US')
WARNING:fbprophet:Changing country holidays from CN to US
```

Add a flag to determine whether appending or changing would be much better .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.