facebook / facebook/prophet

Covid One Off Holidays

Open
#2,589 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

I am looking for some more details on one off holidays described here
https://facebook.github.io/prophet/docs/handling_shocks.html#treating-covid-19-lockdowns-as-a-one-off-holidays

When we look at data before these one off holidays (in April 2016 ) it seems to affect the data. This seems counter intuitive. That is , why is holiday data affecting data previous to their start date?

As well it seems to affect data in the future (june of 2024) a lot more than one would expect.

Should seasonality be used in conjunction with one off holidays to produce better results?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.