facebook / facebook/prophet

Questionable prophet dependency impeding builds on Mac M1

Open
#2,297 1 comment 1 reaction 0 assignees View on GitHub
install py
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

Hi,

Prophet currently depends on LunarCalendar, which in turn depends on PyEphem (https://github.com/brandon-rhodes/pyephem).

PyEphem provides an ephem Python package for performing high-precision astronomy computations. The underlying numeric routines are coded in C (...).

Can you explain in one sentence why you need to depend on a high-precision astronomy library, written in C, in prophet ?

Can't you just use https://pypi.org/project/holidays/ ?

Thanks :)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.