facebook / facebook/prophet

fbprophet "ignores" holidays for some time series datset

Open
#2,284 2 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

Hello, I am using a [store sales time series dataset](kaggle.com/competitions/store-sales-time-series-forecasting/data) where every year, the 1st of January is a holiday and the sales are 0.

I am passing the holidays data frame provided with the dataset which contains the New Years' day tagged as a holiday. However, every time I fit the model and then run for the next year that day always has predictions above 0.

This does not happen with every store of the time series dataset. I've been trying to understand why it happens but I'm not getting anywhere.

Any idea about this kind of behavior?

Regards

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.