facebook / facebook/prophet

[Feature request] Allow specifying `changepoint_ds_lower` and `changepoint_ds_upper`

Open
#1,987 2 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

Do we think it would be useful to allow end users to specify the changepoint range in terms of the dates of the data, rather than the percentage of history (the existing `changepoint_range`)?

I think the default value of `changepoint_range` can have a huge impact on the forecast (e.g. when the time series shows recent growth), but goes largely unnoticed (e.g. as we collect more historical data, the first 80% of history becomes less relevant). Setting a percentage seems a bit more confusing compared to setting specific dates.

We would add these arguments directly to the `Prophet.__init__` method, and make the required changes to `Prophet.set_changepoints()`. I understand that the `__init__` method is already super bloated as is though, so keen to know if people think the added convenience of this feature is worth it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.