facebook / facebook/prophet

[Contribution] Optional Lasso penalties on regressor and trend terms.

Open
#1,986 0 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
20.4k
Forks
4.6k
Avg merge
19h 52m
Merged PRs (30d)
1

Description

Hi

Thanks for helping to maintain this amazing library!

Recently I did some work where I added a Lasso penalty to the regressor, trend and offset terms (i.e. enable the option to change the prior on parameters `k, m, delta` and `beta` to be `double_exponential`, with scale parameter set by the user).

This had a few benefits:

- If a regressor is deemed not useful by the model, it is shrunk close to zero
- If the trend and the regressors interact (e.g. if you have a very strong correlation between trend and a regressor), the trend can do some strange stuff unless it's set to 'flat'. The Lasso penalty can help to avoid this issue automatically.

I was wondering if there would be any interest in adding this as a contribution?

Completely understand it's a big change so you may not want to add it to core. I just thought it was worth asking beforehand, especially as then I could check about best design practices for this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.