facebook / facebook/litho

Relocate Litho dependencies in a location other than JCenter.

Open
#811 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
7.8k
Forks
768
PR merge metrics
No merged PRs in 30d

Description

- [x] I have searched [existing issues](https://github.com/facebook/litho/issues) and this is not a duplicate

We'd like to be able to remove our dependency on jcenter, [as it has been deprecated by Jfrog](https://blog.gradle.org/jcenter-shutdown). The company decided to keep _current_ jcenter downloads available indefinitely, so we're OK for now, but I assume additional updates for Litho will come from maven central (or similar?).

## Version
```
def litho_version = '0.40.0'

api "com.facebook.litho:litho-core:$litho_version"
api "com.facebook.litho:litho-widget:$litho_version"
kapt "com.facebook.litho:litho-processor:$litho_version"

// SoLoader - Litho
api 'com.facebook.soloader:soloader:0.10.1'
implementation 'com.facebook.fbjni:fbjni:0.2.2'

// For testing Litho
testImplementation "com.facebook.litho:litho-testing:$litho_version"

// Sections - Litho
api "com.facebook.litho:litho-sections-core:$litho_version"
api "com.facebook.litho:litho-sections-widget:$litho_version"
compileOnly "com.facebook.litho:litho-sections-annotations:$litho_version"
kapt "com.facebook.litho:litho-sections-processor:$litho_version"
```

## Issues and Steps to Reproduce
Prerequisite: Create sample app that targets Android 12. Remove jcenter() from repositories in build.gradle file(s).
1. Add dependencies (above) to gradle.
2. Sync gradle or rebuild

## Expected Behavior
Litho dependencies are found and downloaded.

~~Link to Code~~

## Build Output
```
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':core:dataBindingMergeDependencyArtifactsProdDebug'.
> Could not resolve all files for configuration ':core:prodDebugRuntimeClasspath'.
> Could not find com.facebook.litho:litho-core:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-core/0.40.0/litho-core-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-core/0.40.0/litho-core-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-core/0.40.0/litho-core-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-core/0.40.0/litho-core-0.40.0.pom
Required by:
project :core > project :network > project :sdui
> Could not find com.facebook.litho:litho-widget:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-widget/0.40.0/litho-widget-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-widget/0.40.0/litho-widget-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-widget/0.40.0/litho-widget-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-widget/0.40.0/litho-widget-0.40.0.pom
Required by:
project :core > project :network > project :sdui
> Could not find com.facebook.litho:litho-sections-core:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-sections-core/0.40.0/litho-sections-core-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-sections-core/0.40.0/litho-sections-core-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-sections-core/0.40.0/litho-sections-core-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-sections-core/0.40.0/litho-sections-core-0.40.0.pom
Required by:
project :core > project :network > project :sdui
> Could not find com.facebook.litho:litho-sections-widget:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-sections-widget/0.40.0/litho-sections-widget-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-sections-widget/0.40.0/litho-sections-widget-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-sections-widget/0.40.0/litho-sections-widget-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-sections-widget/0.40.0/litho-sections-widget-0.40.0.pom
Required by:
project :core > project :network > project :sdui

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':sdui:generateDebugRFile'.
> Could not resolve all files for configuration ':sdui:debugCompileClasspath'.
> Could not find com.facebook.litho:litho-core:0.40.0.
Required by:
project :sdui
> Could not find com.facebook.litho:litho-widget:0.40.0.
Required by:
project :sdui
> Could not find com.facebook.litho:litho-sections-core:0.40.0.
Required by:
project :sdui
> Could not find com.facebook.litho:litho-sections-widget:0.40.0.
Required by:
project :sdui
> Could not find com.facebook.litho:litho-sections-annotations:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-sections-annotations/0.40.0/litho-sections-annotations-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-sections-annotations/0.40.0/litho-sections-annotations-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-sections-annotations/0.40.0/litho-sections-annotations-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-sections-annotations/0.40.0/litho-sections-annotations-0.40.0.pom
Required by:
project :sdui

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

3: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':sdui:javaPreCompileDebug'.
> Could not resolve all files for configuration ':sdui:_agp_internal_javaPreCompileDebug_kaptClasspath'.
> Could not find com.facebook.litho:litho-processor:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-processor/0.40.0/litho-processor-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-processor/0.40.0/litho-processor-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-processor/0.40.0/litho-processor-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-processor/0.40.0/litho-processor-0.40.0.pom
Required by:
project :sdui
> Could not find com.facebook.litho:litho-sections-processor:0.40.0.
Searched in the following locations:
- https://dl.google.com/dl/android/maven2/com/facebook/litho/litho-sections-processor/0.40.0/litho-sections-processor-0.40.0.pom
- https://repo.maven.apache.org/maven2/com/facebook/litho/litho-sections-processor/0.40.0/litho-sections-processor-0.40.0.pom
- https://jitpack.io/com/facebook/litho/litho-sections-processor/0.40.0/litho-sections-processor-0.40.0.pom
- https://s3-us-west-2.amazonaws.com/si-mobile-sdks/android/com/facebook/litho/litho-sections-processor/0.40.0/litho-sections-processor-0.40.0.pom
Required by:
project :sdui
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.