facebook / facebook/litho

Scale animation goes out of parent bounds.

Open
#585 17 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
7.8k
Forks
768
PR merge metrics
No merged PRs in 30d

Description

- [x] I have searched [existing issues](https://github.com/facebook/litho/issues) and this is not a duplicate

I really don't sure it's really a bug, because we don't have such topic in the issue tracker. However it's not clear from documentation, how to deal with such kind of implementation, which is pretty simple.

[Gif showing the issue.](https://imgur.com/a/3ecT8Ju)

## Version
ext.litho = '0.29.0'

## Issues and Steps to Reproduce
1) Simple View Row with Picasso Image on background with `positionType(YogaPositionType.ABSOLUTE)` and few other Views on top.
2) Try to animate background ImageView from 0x scale to 1x> scale (including interpolation).

## Actual Behavior
Background View has no restrictions to go out of parent, during animation. Gif above, showing the issue.
**Note 1.** Setting params for parent Views like size, cllip children, parent, etc doesn't work.
**Note 2.** By manually setting scale (not animation) to the Background Image (for ex. 2f) will work Ok! Image would be scaled inside it's bounds.

## Expected Behavior
Background Image should not go outside it's bounds. Only in case of setting other params, like clip to children, parent, etc.

## Link to Code
Will be added, if necessary,

Regards,

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.