facebook / facebook/lexical

Feature: `getFormat` and `getFormatType` methods should be implemented in `@lexical/react/LexicalDecoratorBlockNode`.

Open
#4,311 1 comment 0 reactions 0 assignees View on GitHub
enhancement other
Dominant language
TypeScript
Stars
23.9k
Forks
2.2k
Avg merge
1d 16h
Merged PRs (30d)
61

Description

`getFormat` and `getFormatType` methods should be implemented in `@lexical/react/LexicalDecoratorBlockNode`.

Using `BlockWithAlignableContents` component should get same feature of format type with `ElementNode`.

And it may be better to export all constant variables from `LexicalConstants.ts` so that we can implement some features in unified standard, for example, I need `ELEMENT_FORMAT_TO_TYPE` here.

Contributor guide

Open the contributing guide

Research direction

Start by reading @lexical/react/LexicalDecoratorBlockNode and the BlockWithAlignableContents component to understand how formatting is currently handled. Check LexicalConstants.ts for ELEMENT_FORMAT_TO_TYPE and determine the needed exports; done means both methods provide ElementNode-compatible format behavior for BlockWithAlignableContents.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.