facebook / facebook/infer

FALSE NEGATIVE: PULSE_RESOURCE_LEAK misses an unclosed JDBC connection

Open
#2,111 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
OCaml
Stars
15.7k
Forks
2.1k
Avg merge
19h 36m
Merged PRs (30d)
13

Description

Hi, I found a false negative in Infer 1.3.0 when the returned Connection is never closed or returned.

**Affected tool**

`Infer 1.3.0`

**Affected checker**

`Infer PULSE_RESOURCE_LEAK`

**Minimal reproducer**

```java
import java.sql.DriverManager;
import java.sql.SQLException;

class InferLeakJdbc {
void test() throws SQLException {
DriverManager.getConnection("jdbc:test");
}
}
```

**Reproduction command**

```bash
infer --version
infer run --pulse --bufferoverrun --enable-issue-type PULSE_RESOURCE_LEAK -- javac spotbugs-to-infer-resourceleak-fn-jdbc.java
```

**Current behavior**

Infer completes successfully but produces no `PULSE_RESOURCE_LEAK` finding.

**Expected behavior**

Infer should report `PULSE_RESOURCE_LEAK` at line 6 because the returned Connection is never closed or returned.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.