facebook / facebook/hhvm

Potential deadlock in PCRE cache

Open
#9,032 1 comment 0 reactions 0 assignees View on GitHub
probably easy
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

In 2014 I improved HHVM's PCRE compilation cache, introducing a new [thread-safe container](https://github.com/facebook/hhvm/blob/master/hphp/util/concurrent-lru-cache.h) to hold cache entries. I also published the container class as a separate library. Another user of the library reported a deadlock issue, and it appears that it may also affect HHVM. If an application uses many different regexes and traffic is heavy, HHVM may globally deadlock. I'm not an HHVM user anymore, but out of courtesy I am forwarding the issue. The deadlock issue is discussed at https://github.com/tstarling/thread-safe-lru/issues/5 and the proposed fix is https://github.com/tstarling/thread-safe-lru/pull/6 .

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.