facebook / facebook/hhvm

Missing some of libsodium constants

Open
#8,608 3 comments 0 reactions 0 assignees View on GitHub
probably easy
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

HHVM is missing some `SODIUM_CRYPTO_GENERICHASH_*` constants.

see : https://www.php.net/manual/en/sodium.constants.php

the missing constants :
- `const int SODIUM_CRYPTO_GENERICHASH_BYTES = 32;`
- `const int SODIUM_CRYPTO_GENERICHASH_BYTES_MAX = 64;`
- `const int SODIUM_CRYPTO_GENERICHASH_BYTES_MIN = 16;`

polyfill : https://github.com/nuxed/crypto/blob/master/src/Nuxed/Crypto/_Private/polyfill.hack

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.