facebook / facebook/hhvm

add setEncryptionIndex and setEncryptionName... introduces one regression

Open
#8,462 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

### HHVM Version

swalk@lab-7:~/extra/play.031119a/hhvm$ hphp/hhvm/hhvm --version
HipHop VM 4.1.0-dev (rel)
Compiler: heads/master-0-g34f50870635027dfef56010248ad1fa2eaad52f1
Repo schema: 7d5b4c62555b1d2d37ca7ac06ba86fae717b3bf1

### Operating System and Version

Fails on aarch64 and x64 both running Ubuntu 16.04

swalk@lab-7:~/extra/play.031119a/hhvm$ uname -a
Linux 1scrb-7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:15:48 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux

swalk@dellx3:~/play.031119a/hhvm$ uname -a
Linux dellx3 4.4.0-57-generic #78-Ubuntu SMP Fri Dec 9 23:50:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

### Standalone code, or other way to reproduce the problem

hphp/test/run -v -m interp
hphp/test/run -v -m interp -r
hphp/test/run -v -m jit -a '-vEval.JitPGO=0'
hphp/test/run -v -m jit -r -a '-vEval.JitPGO=0'
hphp/test/run -v -m jit -a '-vEval.JitPGO=1'
hphp/test/run -v -m jit -r -a '-vEval.JitPGO=1'

### Actual result

Post-processed report below. Fails all 6 option sets

hphp/test/slow/ext_zlib/ziparchive_setencryption.php | F | F | F | F | F | F |

### Expected result

Pass

swalk@lab-7:~/extra/play.031119a/hhvm$ ./hphp/hhvm/hhvm -c /mnt/diskb/swalk/play.031119a/hhvm/hphp/test/slow/config.ini -vEval.EnableArgsInBacktraces=true -vEval.EnableIntrinsicsExtension=true -vEval.HHIRInliningIgnoreHints=false -vRepo.Local.Mode=-- -vRepo.Central.Path=/mnt/diskb/swalk/play.031119a/hhvm/hphp/hhvm/verify.hhbc -vEval.Jit=0 -vEval.ProfileHWEnable=false -vEval.HackCompilerExtractPath='/mnt/diskb/swalk/play.031119a/hhvm/hphp/hhvm/hackc_%{schema}' -vEval.EmbeddedDataExtractPath='/mnt/diskb/swalk/play.031119a/hhvm/hphp/hhvm/hhvm_%{type}_%{buildid}' -vResourceLimit.CoreFileSize=0 --file 'hphp/test/slow/ext_zlib/ziparchive_setencryption.php'

Fatal error: unknown exception

Same failure on x64 machine.

Suspect this commit.
https://github.com/facebook/hhvm/commit/058191f4f82e46ae1cc0155fda7bf7483a07be70

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.