facebook / facebook/hhvm

HHVM Debugger: Surface Hack ..., introduces regression

Open
#8,456 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

### HHVM Version
lab-7:~/extra/play.022819a/hhvm$ hphp/hhvm/hhvm --version
HipHop VM 4.1.0-dev (rel)
Compiler: heads/master-0-ga3638a796bb94fb74383a273031b068d6113efeb
Repo schema: e87c35514d08876eba0bd8bc3dc6c92468dee9c8

swalk@dellx3:~/play.022819a/hhvm$ hphp/hhvm/hhvm --version
HipHop VM 4.1.0-dev (rel)
Compiler: heads/master-0-ga3638a796bb94fb74383a273031b068d6113efeb
Repo schema: e87c35514d08876eba0bd8bc3dc6c92468dee9c8

### Operating System and Version
Two machines - both Ubuntu 16.04

uname -a
Linux lab-7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:15:48 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux

swalk@dellx3:~/play.022819a/hhvm$ uname -a
Linux dellx3 4.4.0-57-generic #78-Ubuntu SMP Fri Dec 9 23:50:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

### Standalone code, or other way to reproduce the problem

hphp/test/run -v -m interp
hphp/test/run -v -m interp -r
hphp/test/run -v -m jit -a '-vEval.JitPGO=0'
hphp/test/run -v -m jit -r -a '-vEval.JitPGO=0'
hphp/test/run -v -m jit -a '-vEval.JitPGO=1'
hphp/test/run -v -m jit -r -a '-vEval.JitPGO=1'

### Actual result
Post-processed report below. Columns line up with option sets above.

hphp/test/slow/ext_vsdebug/options.php | F | F | F | F | F | F |

### Expected result

Pass

This showed up in my testing of 02/28/2019.

I suspect this checkin.
https://github.com/facebook/hhvm/commit/64822a44483a55f897318bb2584d0853b4bbcab2

Contributor guide

Open the contributing guide

Research direction

Start with hphp/test/slow/ext_vsdebug/options.php and run the listed interp and JIT commands on the referenced HHVM revision, comparing behavior with and without Eval.JitPGO. Inspect commit 64822a44483a55f897318bb2584d0853b4bbcab2 and the debugger-related changes it introduced; done means the test passes in all six option sets.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, php, ubuntu
Domain
devtools, operating-systems, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.