facebook / facebook/hhvm

Support parameter hints in hh_client LSP

Open
#8,199 1 comment 0 reactions 0 assignees View on GitHub
feature request hack
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

### HHVM Version
Any

### Operating System and Version
Any

### Standalone code, or other way to reproduce the problem

Hack typechecker just added support for signature help in the latest version (https://github.com/facebook/hhvm/commit/7874525f86ad1621d5f8e5a5f23d318b861ebc46). While this shows function/parameter signature when typing, it can also further annotate the hint using documentation:

1. Description can be shown during hover. TypeScript example:
![image](https://user-images.githubusercontent.com/341507/40014480-8c760f7e-5765-11e8-98e5-e92b0b28aed3.png)

2. Specific parameter description can be shown during completing by parsing `@param` comments. TypeScript example:

![image](https://user-images.githubusercontent.com/341507/40014545-b1d425a8-5765-11e8-8b2b-70bdcd393a40.png)
![image](https://user-images.githubusercontent.com/341507/40014555-b6f68738-5765-11e8-9468-a5cd48a93ccc.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.