facebook / facebook/hhvm

Don't spam server logs if CLI server receives an access=7 INI setting with the current value

Open
#8,067 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

### HHVM Version

3.23.2

### Standalone code, or other way to reproduce the problem

Use CLI server, run anything

### Expected result

A whole load of log spam, eg

```
CLI server received an invalid INI setting: date.timezone (access = 7)
CLI server received an invalid INI setting: mbstring.substitute_character (access = 7)
CLI server received an invalid INI setting: memcache.hash_function (access = 7)
CLI server received an invalid INI setting: memcache.hash_strategy (access = 7)
```

### Actual result

No log spam for ini settings where CLI client config matches server config

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.