FindLibZip.cmake code should be reordered
Open
build
probably easy
wishlist
- Dominant language
- C++
- Stars
- 18.7k
- Forks
- 3.1k
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 2
Description
### HHVM Version
current master
- reading the version from the header file should come before the call to FindPackageHandleStandardArgs
- LIBZIP_VERSION can then be passed with the argument "VERSION_VAR" to FPHSA, so it can print the found version and do version selection if a minimum version is specified in the find_package() call
- these variables are usually not cached in upstream CMake modules
- reading the version from the header could be omitted in case a version is returned from pkg-config
Contributor guide
Assessment
This issue has not been assessed yet.