facebook / facebook/hhvm

Getting ext-pgsql into core

Open
#7,200 1 comment 0 reactions 0 assignees View on GitHub
external feature request
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

This is mostly so I know what needs to be done once the main diff lands. Will also allow others to contribute if they want to :)
- [x] land main diff (#6849)
- [ ] Docblocks in HNI file
- [ ] HHI file (not the Hack friendly version that's in hhvm-pgsql :( )
- [ ] Document PHP incompatibilities (mostly that the resource argument isn't optional. See the README in hhvm-pgsql for a more thorough list)
- [x] Add `libpq5` as an install dependancy for pre-built packages (hhvm/packaging#146)
- [x] Poke people to make sure the build machines have `libpq-dev` installed

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.