facebook / facebook/hhvm

Empty doc_root directive not ignored

Open
#6,823 0 comments 0 reactions 0 assignees View on GitHub
mid-pri php5 incompatibility probably easy
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

According to http://php.net/manual/en/ini.core.php#ini.doc-root, the `doc_root` directive should only be used if non-empty. However, hhvm seems to use it if it is empty.

`php.ini`

```
doc_root =
```

`index.php`

```

```

When `hhvm -m server -p 8088 -d hhvm.server.source_root=./` is running, the command `curl localhost:8088` returns `RequestInitDocument Not Found`, and the hhvm command line shows `Notice: File could not be loaded: /index.php`. Replacing `php.ini` with a blank file fixes this, as does running `php -S localhost:8088 ./index.php` instead of hhvm.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.