facebook / facebook/hhvm

move_uploaded_file permission

Open
#6,788 0 comments 0 reactions 0 assignees View on GitHub
mid-pri
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

When i set system setting session.save_path = "0;0644;/path/to/sessions"
It not work, and function move_uploaded_file set file permission mode to 0600.
And my server nginx don't have permission to read uploaded files.
I start hhvm service as umask 022 in my /etc/init/hhvm.conf
How I make correct this?
For test, I use this script "upload_file.php":

```
";
if ($_FILES["file"]["error"] > 0)
{
echo "Return Code: " . $_FILES["file"]["error"] . "
";
}
else
{
echo "Upload: " . $_FILES["file"]["name"] . "
";
echo "Type: " . $_FILES["file"]["type"] . "
";
echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb
";
echo "Temp file: " . $_FILES["file"]["tmp_name"] . "
";
move_uploaded_file($_FILES["file"]["tmp_name"], dirname(__FILE__).'/' . $_FILES["file"]["name"]);
echo "Stored in: " . dirname(__FILE__).'/' . $_FILES["file"]["name"]."
";
echo "File permission (mode): ".substr(sprintf('%o', fileperms(dirname(__FILE__).'/' . $_FILES["file"]["name"])), -4);

}
```

And for submit page, I use:

```

Filename:


```

And result:

```
Session save path: 0;0644;/srv/tmp
Upload: test.txt
Type: text/plain
Size: 0.005859375 Kb
Temp file: /srv/tmp/Pp3yfM
Stored in: /srv/www/test/test.txt
File permission (mode): 0600
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.