facebook / facebook/hhvm

Allow whitelisting unrecognized __Foo attributes with user_attributes= in .hhconfig

Open
#4,932 5 comments 0 reactions 0 assignees View on GitHub
hack
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

Revert of https://github.com/facebook/hhvm/commit/ec1031e25c189a12e0e89eb151c796da0b8fcdb2 ?

Potentially more useful for third-party code than FB - eg:
- vendor/foo/ uses a new user attribute from 3.7 which doesn't have runtime effects
- however, the main project keeps supporting (and being developed on) older versions

Otherwise, this is potentially an artificial restriction for library compatibility/feature adoption.

Some future attributes may have runtime effects, but leaving that to the user seems reasonable.

cc @elgenie

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.