facebook / facebook/hhvm

hdf argument linter generating possibly incorrect warning messages

Open
#4,306 2 comments 0 reactions 0 assignees View on GitHub
ini
Dominant language
C++
Stars
18.7k
Forks
3.1k
Avg merge
1h 47m
Merged PRs (30d)
2

Description

Running:

hhvm --config-value hhvm.log.runtime_error_reporting_level=8191 phpinfo.php
Possible bad config node: hhvm
....

The "Possible bad config node" message comes from within the guts of Hdf::lintImpl when the complement of hdf_is_visited is propagated up the hdf hierarchy, with some overly clever coding to prune away children. The child that is added to the report vector is hhvm.log.runtime_error_reporting_level, but the ".log.runtime_error_reporting_level" is effectively discarded by the time the recursive lintImpl does its thing.

I'm wondering if the linter is run prematurely (eg, before the CLI arguments are acted on), or if this --config-value syntax isn't right anymore. Or perhaps this is vestigal brokenness from the days when hdf was the main way configs were handled.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.