facebook / facebook/hermes

Optimize bigint division (div_rem::compute) for fast case

Open
#1,850 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11.3k
Forks
859
Avg merge
1h 30m
Merged PRs (30d)
3

Description

Somewhere along https://github.com/facebook/hermes/blob/517e48e9e47d06d82bd0a874a0412f6d9c8cfdc9/lib/Support/BigIntSupport.cpp#L1797-L1798

If `lhs.numDigits < rhs.numDigits`, the result could be trivially optimized to `[0, lhs]`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.