facebook / facebook/hermes

Move `prettier-plugin-hermes-parser` to Prettier repo

Open
#1,707 13 comments 0 reactions 1 assignee Claimed by @pieterv View on GitHub
enhancement
Dominant language
JavaScript
Stars
11.3k
Forks
859
Avg merge
1h 30m
Merged PRs (30d)
3

Description

I'm working on adding `hermes` parser in Prettier repo https://github.com/prettier/prettier/pull/17520, currently it passed all Prettier tests except [some tests are disabled](https://github.com/prettier/prettier/pull/17520/files#diff-6b9fe7dbaa8d4d008676d837b81006d17b261b8731a8dc792ae56da668c72cd0) due to parser issues, I'll open issues about them.

I can see most changes are in this repo https://github.com/pieterv/prettier/tree/hermes-v2-backport ?

1. What do you think about moving to Prettier?
2. Still need Prettier v2 support? ([This commit](https://github.com/prettier/prettier/commit/b771394c0a5917318c86fce29519fe89f739fb85) is turning async apis to sync)
3. Are there additional supports required from Prettier?
4. Are you willing to upstream changes? (Most likely `hook` and `match` syntax support)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.