facebook / facebook/hermes

Adding Node-API support to Static Hermes

Open
#1,610 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
11.3k
Forks
859
Avg merge
1h 30m
Merged PRs (30d)
3

Description

There is an existing PR to add Node-API to Hermes (https://github.com/facebook/hermes/pull/1377). In order to add support Static Hermes, we need to do a few things in addition to what is currently done in the PR:

1. Pull the latest version of the Node-API implementation from https://github.com/microsoft/hermes-windows
2. Add the tests for the Node-API implementation from that repo
3. Put the implementation in a separate directory in the `API` directory
4. Add a separate CMake target for the Node-API implementation

Contributor guide

Open the contributing guide

Research direction

Start by comparing the existing Node-API work in PR 1377 with the implementation and tests in microsoft/hermes-windows. Inspect the API directory and CMake configuration to determine the separate implementation location and target. Done means the updated implementation and tests are included and the separate CMake target builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, javascript, node.js
Domain
build-system, compilers, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.