facebook / facebook/hermes

Property checking in host objects

Open
#1,490 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
11.3k
Forks
859
Avg merge
1h 30m
Merged PRs (30d)
3

Description

## Bug Description
The behaviour described below has been noticed by us since many years now but we never had an issue with it until now.
Now that we run three.js on top of host objects, we have less flexibility on how they could behave.
I also acknowledge that this wouldn't be a problem if we were using native state instead of host objects.

The following:
```
!!("put any name" in hostHobject) // Will always return true no matter what
```

@tmikov there is probably a semantic that I am missing here, if you could refresh me on what is the semantic here? Could this be a bug? I'm not sure.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the `in` expression against a host object in Hermes and inspect the host-object property-checking path. Clarify the intended JavaScript semantics with the issue’s reporter, then add regression coverage showing the expected result for an absent property. Done means the behavior is specified and the check no longer always returns true.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.